Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure bundles are not treated as virtual product on product_sync #2334

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

rawdreeg
Copy link
Contributor

Changes proposed in this Pull Request:

WC_Product::is_virtual() returns a false positive for unassembled bundle products. This PR adds a check to ensure bundle products are not hidden unless explicitly marked as hidden.

Closes #1769.

  • [ x] Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

  1. Start with Product Bundles and Facebook for WooCommerce connected and synced with a FB catalog;
  2. Create a bundled product with the default settings — in my case I have added two simple products to the bundle;
  3. In the Facebook settings for that product, switch Facebook sync to Sync and show in the catalog and save the changes
  4. See that the change wasn't saved;
  5. Go to Facebook's Catalog Manager > All Items (in the filters) and see that the bundled product is there but not visible
  6. Switch to this branch and go back to step 4 and save
  7. Observe the changes remain, and the product is now visible on Facebook's Catalog Manager

Changelog entry

Fix - Ensure bundles are not treated as virtual products on product_sync

@rawdreeg rawdreeg requested a review from a team October 20, 2022 13:56
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Oct 20, 2022
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @rawdreeg

@rawdreeg rawdreeg merged commit 514e4ed into develop Oct 21, 2022
@rawdreeg rawdreeg deleted the fix/bundle_product_hidden_on_sync branch October 21, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled Products Are Automatically Hidden From The Catalog (But Sync Successfully)
2 participants